Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DEV_MODE to be set to true. #457

Closed
wants to merge 1 commit into from
Closed

Conversation

ebadiere
Copy link
Contributor

@ebadiere ebadiere commented Dec 5, 2023

Set the DEV_MODE to true in the JSON RPC Relay in order to return the decoded contract revert reason.

Related issue(s):

Fixes #456

@ebadiere ebadiere added the Bug An error that causes the feature to behave differently than what was expected based on design. label Dec 5, 2023
@ebadiere ebadiere added this to the 2.17.0 milestone Dec 5, 2023
@ebadiere ebadiere self-assigned this Dec 5, 2023
@ebadiere ebadiere force-pushed the 456-DEV_MODE-setting branch from eb5f060 to c32e986 Compare December 5, 2023 20:42
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed? Dev mode should be false, by default, as it's not the default behaviour of the relay. If dev mode is truly needed then, we need to change it in the local.json configuration OR in the test itself, by setting the process.env.DEV_MODE to true.

local.json configuration is used for all CI that run local-node as they used latest and greatest versions and features, while this change will alter the mainnet configuration, which should mimic the actual mainnet.

@ebadiere ebadiere closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

DEV_MODE needs to be set to true in the local node.
2 participants